Allow site arg by domain name again for backfill_figures_daily_metrics #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not calling self.get_site_ids I had allowed only an integer value
bryanlandia
force-pushed
the
bryan/fix-daily-backfill-sites
branch
from
79c4cf2 to
bcc7770
Compare
estherjsuh
approved these changes
Jun 23, 2021
| @@ -51,13 +51,16 @@ def handle(self, *args, **options): | |||
| date_start, date_end | |||
| )) | |||
|
|
|||
| # don't pass multiple site ids to tasks | |||
| site_id = None if not options['site'] else self.get_site_ids(options['site']) | |||
There was a problem hiding this comment.
@bryanlandia can we use options['site'] instead of self.get_site_ids(options['site']) here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR wasn't quite right, since it did away with the option to pass a domain name instead of Site id—way more convenient. This brings back that ability for backfill_figures_daily_metrics