Handle old, slash-separated course ids and course-vX:... style #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlandia
force-pushed
the
bryan/frontend-handle-slash-sep-course-ids
branch
from
8d760fa to
20ac183
Compare
johnbaldwin
approved these changes
May 27, 2021
There was a problem hiding this comment.
Looks reasonable to me. Too bad we don't have unit testing on the front end. Are you able to get this to work in Figures devsite @bryanlandia or did you test it elsewhere?
I would like to get @grozdanowski OK on this before we merge it in case he sees something I don't
|
Thanks @johnbaldwin I have just been testing directly against DHIS2 staging :D And yes, it's working for old and new style course ids. |
grozdanowski
approved these changes
May 28, 2021
|
Thanks guys. I'll rebase and merge |
Allows Figures to run on sites with courses created in e.g., 2015
bryanlandia
force-pushed
the
bryan/frontend-handle-slash-sep-course-ids
branch
from
20ac183 to
c3df86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Figures to run on sites with courses created in e.g., 2015
Split route path into two options: if there are no forward-slashes we assume course id is like course-v1:xxx
I didn't figure out how to get a nice named match param into my regex for that one but if you see how to, feel free.
Second one looks specifically for a course id style with two slash separations.