Juniper upgrade - Multi-asset build and static location flexibility #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbaldwin
requested review from
OmarIthawi,
estherjsuh,
grozdanowski and
melvinsoft
* New build script, 'multi-build' added to build multiple asset bundles
* Now two asset bundles are created
* One for pre-Juniper with REM_BASE=10
* Another for Juniper+ with REM_BASE=16
* 'publicPath' removed from webpack-stats.json file to allow for Webpack
to specify the static assets URL
* Which of the two asset bundle is determiend by the Open edX release
version
johnbaldwin
force-pushed
the
john/update-fe-asset-handling
branch
from
50abe8b to
8240f89
Compare
|
Thanks @grozdanowski ! I added another commit that fixes the default build and sets it as REM_BASE 16 |
estherjsuh
approved these changes
May 26, 2021
OmarIthawi
approved these changes
May 27, 2021
|
@johnbaldwin Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to specify the static assets URL
version
NOTE: This does not solve the "need to build assets for deployment" issue. So currently, we're still building an "asset bundle" deadend branch until we automate building assets into the dist bundle to push to PyPI