Fix handling when general course data has null metrics #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a course is created after the last daily pipline then there is not a CourseDailyMetrics record for the course. This then causes the 'courses/general' API endpoint to have `null` for the 'metrics' key. This commit is one way to address that. What it does is in the client's courses page check if there is a value for metrics and set the values to 'N/A' if the value is not there. There are other solutions, such as provide default '0' values in the metrics code. But this way, we know that there are not metrics values instead of metrics collected with zero value, which gives some clue that there is an issue that needs to be investigated
|
@grozdanowski In case you don't get to reviewing this before I push it out, if you're not happy with what I did to fix the error on the front end, feel free to fix it how you wish. I would like to give a clue in the UI if there are missing metrics data rather than zero'd out "initial state" metrics data (initial state meaning when a course is first created), but your call |
melvinsoft
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
@johnbaldwin Ship it, if @grozdanowski has a better solution, we can change it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a course is created after the last daily pipline then there is not
a CourseDailyMetrics record for the course. This then causes the
'courses/general' API endpoint to have
nullfor the 'metrics' key.This commit is one way to address that. What it does is in the client's
courses page check if there is a value for metrics and set the values to
'N/A' if the value is not there.
There are other solutions, such as provide default '0' values in the
metrics code. But this way, we know that there are not metrics values
instead of metrics collected with zero value, which gives some clue that
there is an issue that needs to be investigated
https://appsembler.atlassian.net/browse/RED-1696