Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sqlparse dependency and bump figures versioun to 0.4.dev1 #291

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

johnbaldwin
Copy link
Contributor

This PR addresses the issue that sqlparse is not installed on edx-platform Hawthorn. Also changing the Figures version number for 0.4.dev? releases, following https://www.python.org/dev/peps/pep-0440/

To note, Django 2.2.x has a dependency on sqlparse. See here: https://github.com/django/django/blob/stable/2.2.x/setup.py#L86

@melvinsoft
Copy link
Contributor

@johnbaldwin Ship it, let's try this on Staging.

@thraxil thraxil merged commit 2803fec into master Dec 4, 2020
@thraxil
Copy link
Contributor

thraxil commented Dec 4, 2020

Ha! clicked the wrong button and merged it. Sorry! Count that as a LGTM from me.

@johnbaldwin johnbaldwin deleted the john/update-figures-dependencies branch December 4, 2020 12:31
@johnbaldwin
Copy link
Contributor Author

No worries, @thraxil I was wondering when I saw the Slack notification ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants