Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the comparison showing N/A when comparing to zero #277

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

grozdanowski
Copy link
Contributor

As per title. Essentially it would check if the past value exists, however it treated 0 (zero) the same way as undefined or Null. Now fixed.

@johnbaldwin
Copy link
Contributor

johnbaldwin commented Oct 28, 2020

@grozdanowski You can't add the compiled assets to master. Do you need me to redo your commit?

Copy link
Contributor

@johnbaldwin johnbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove compiled assets

@johnbaldwin
Copy link
Contributor

I killed travis so it wouldn't be in the queue, there's no python in this PR, and the travis delays are slowing us down

@grozdanowski
Copy link
Contributor Author

@johnbaldwin compiled assets removed.

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files          41       41           
  Lines        2161     2161           
=======================================
  Hits         1982     1982           
  Misses        179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2908dba...ef31859. Read the comment docs.

@grozdanowski
Copy link
Contributor Author

@johnbaldwin changes made, just waiting on your approval and you can merge it.

Copy link
Contributor

@johnbaldwin johnbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the assets, @grozdanowski !

@johnbaldwin
Copy link
Contributor

@grozdanowski I merged master in here and will merge this PR into master after the tests finish

@johnbaldwin johnbaldwin merged commit 085d077 into master Oct 30, 2020
@johnbaldwin johnbaldwin deleted the matej-work/fix-stat-comparisons branch October 30, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants