-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the comparison showing N/A when comparing to zero #277
Conversation
@grozdanowski You can't add the compiled assets to master. Do you need me to redo your commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove compiled assets
I killed travis so it wouldn't be in the queue, there's no python in this PR, and the travis delays are slowing us down |
@johnbaldwin compiled assets removed. |
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 41 41
Lines 2161 2161
=======================================
Hits 1982 1982
Misses 179 179 Continue to review full report at Codecov.
|
@johnbaldwin changes made, just waiting on your approval and you can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the assets, @grozdanowski !
@grozdanowski I merged master in here and will merge this PR into master after the tests finish |
As per title. Essentially it would check if the past value exists, however it treated 0 (zero) the same way as undefined or Null. Now fixed.