Fix certificates count as proxy for course completions #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbaldwin
force-pushed
the
john/fix-site-cert-metrics
branch
2 times, most recently
from
627c4fe to
e0dcc02
Compare
Reworked function to get the latest sum of cerfificates across courses for the site. This is done by querying CourseDailyMetrics. * Added new test module to focus on testing certificate metrics This is a workaround. It fixes the metric, but is really just a patch. What needs to happen is to rethink this metric, what we want to say and how to efficiently (storage and query performance) manage certificates achived over time. Especially since we only want to capture data as they change
johnbaldwin
force-pushed
the
john/fix-site-cert-metrics
branch
from
e0dcc02 to
70ae18b
Compare
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 41 41
Lines 2129 2131 +2
=======================================
+ Hits 1954 1956 +2
Misses 175 175
Continue to review full report at Codecov.
|
melvinsoft
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked function to get the latest sum of cerfificates across courses
for the site. This is done by querying CourseDailyMetrics.
This is a workaround. It fixes the metric, but is really just a patch. What needs to happen is to rethink this metric, what we want to say and how to efficiently (storage and query performance) manage certificates achived over time.
Especially since we only want to capture data as they change