fix: importsNotUsedAsValues を error に変更 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 71.36% 71.37%
=======================================
Files 58 58
Lines 3932 3933 +1
Branches 369 369
=======================================
+ Hits 2806 2807 +1
Misses 757 757
Partials 369 369
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MikuroXina
changed the title
m1sk9
approved these changes
Aug 26, 2022
|
🎉 This PR is included in version 1.25.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change:
tsconfig の変更
Cause of the Problem (問題の原因)
これまでコードレビューにおいて
import typeを指摘していましたが, これでは作業効率が少し悪くなっていました.Details of implementation (実施内容)
tsconfig.jsonにてimportsNotUsedAsValuesをerrorに設定し, 値をimportしていない場合の通常のimportはエラーになるようにしました.