Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Judging の強化 #222

Merged
merged 8 commits into from
May 31, 2022
Merged

feat: Judging の強化 #222

merged 8 commits into from
May 31, 2022

Conversation

MikuroXina
Copy link
Collaborator

Issue: #177

Type of Change:

機能の新規追加

Details of implementation (実施内容)

@MikuroXina MikuroXina self-assigned this May 31, 2022
@MikuroXina MikuroXina requested a review from m1sk9 May 31, 2022 07:50
@m1sk9 m1sk9 linked an issue May 31, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #222 (c206163) into main (36fcb44) will decrease coverage by 0.22%.
The diff coverage is 51.72%.

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   51.46%   51.23%   -0.23%     
==========================================
  Files          42       43       +1     
  Lines         785      808      +23     
  Branches      122      125       +3     
==========================================
+ Hits          404      414      +10     
- Misses        261      272      +11     
- Partials      120      122       +2     
Flag Coverage Δ
unittests 51.23% <51.72%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/model/judging-status.ts 50.00% <50.00%> (ø)
src/service/judging.ts 63.88% <50.00%> (ø)
src/adaptor/random.ts 12.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fcb44...c206163. Read the comment docs.

m1sk9
m1sk9 previously approved these changes May 31, 2022
@MikuroXina MikuroXina merged commit 732d56a into main May 31, 2022
@MikuroXina MikuroXina deleted the feat/#177 branch May 31, 2022 09:07
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: †HARACHO ONLINE JUDGEMENT SYSTEM† の再現性を強化
3 participants