fix: エラーを一度しか出さないように修正 (#751)

approvers · Feb 25, 2023 · 261050f · 261050f
1 parent cdd3fc0
commit 261050f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/src/service/command/meme.test.ts b/src/service/command/meme.test.ts
@@ -12,14 +12,15 @@ describe('meme', () => {
    * https://github.com/approvers/OreOreBot2/pull/600
    */
 
-  it('delete message', async () => {
+  it('report error only once', async () => {
     const fn = vi.fn();
     await responder.on(
-      createMockMessage(
-        parseStringsOrThrow(['fukueki', 'こるく'], responder.schema),
-        fn
-      )
+      createMockMessage(parseStringsOrThrow(['hukueki'], responder.schema), fn)
     );
-    expect(fn).not.toHaveBeenCalled();
+    expect(fn).toHaveBeenCalledOnce();
+    expect(fn).toHaveBeenCalledWith({
+      title: '引数が不足してるみたいだ。',
+      description: '服役できなかった。'
+    });
   });
 });
diff --git a/src/service/command/meme.ts b/src/service/command/meme.ts
@@ -73,10 +73,16 @@ export class Meme implements CommandResponder<typeof SCHEMA> {
       }
     });
     builder.fail(() => {
-      void reportError(message, meme);
+      // ignore the error
     });
 
-    const argv = await builder.parseAsync();
+    let argv: Record<string, unknown>;
+    try {
+      argv = await builder.parseAsync();
+    } catch {
+      await reportError(message, meme);
+      return;
+    }
 
     if (argv.help) {
       await message.reply({