Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before fail #55

Closed
wants to merge 6 commits into from
Closed

Before fail #55

wants to merge 6 commits into from

Conversation

aleclerc-cio
Copy link
Contributor

@aleclerc-cio aleclerc-cio commented Nov 22, 2024

This should be small

Small pull requests are great and easy for me to understand and accept
Please try prefix every commits in the pull request with Arlo's git notation

Prefix Meaning
e development enviroment only - not production
d documentation only
t tests only
R!! Refactoring
B!! Bug Fix
F!! New Feature

But it's not small!

Then you should setup a remote pairing session with Llewellyn ( llewellyn.falco@gmail.com )
Usually the sessions are between 45-90 minutes.

assuming you still feel it is small, please include

Description

A description of what the PR achieves.

The solution

Outline the implementation.
Any tests that are affected.

Notation

I prefer lots of very small commits prefixed with Arlo's git notation

Summary by Sourcery

Enhance the CI workflow by adding a matrix strategy to test across multiple operating systems and update the actions to their latest versions.

CI:

  • Add a matrix strategy to the CI workflow to run tests on Windows, Ubuntu, and macOS platforms.
  • Update the checkout action to version 4 in the CI workflow.
  • Update the Go setup action to version 5.1.0 and specify Go version 1.21.13 in the CI workflow.

Copy link

sourcery-ai bot commented Nov 22, 2024

Reviewer's Guide by Sourcery

This PR updates the GitHub Actions workflow configuration to support multi-platform testing and upgrades action versions. The changes include running tests on Windows, Ubuntu, and macOS, implementing a matrix strategy, and updating the versions of checkout and setup-go actions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implemented multi-platform testing strategy in GitHub Actions workflow
  • Added matrix strategy configuration with Windows, Ubuntu, and macOS
  • Disabled fail-fast behavior to allow all platform tests to complete regardless of failures
  • Updated runner configuration to use matrix OS value
.github/workflows/test.yml
Updated GitHub Actions dependencies to latest versions
  • Upgraded checkout action from v2 to v4
  • Upgraded setup-go action from v2.2.0 to v5.1.0
  • Added explicit Go version specification (1.21.13)
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants