Some style and general improvements #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k from the project
Without https the link to the blog doesn't work.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @kudashevs - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -67,7 +67,7 @@ Examples | |||
| --- | |||
| ApprovalTests eats it own dogfood, so the best examples are in the source code itself. | |||
|
|
|||
| None the less, Here's a quick look at some | |||
| None the less, here's a quick look at some | |||
There was a problem hiding this comment.
nitpick (typo): Fixing the typo in 'None the less' improves the document's professionalism.
There was a problem hiding this comment.
You'd better ask the author of the text, not me, why they've used this interesting verbiage.
And this is actually the archaic way of spelling "nonetheless", so why not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It wasn't possible to make this PR small, sorry. It fixes a lot of formatting issues; that's why it might seem bloated, but it really isn't.
So, I would like to propose some style and general improvements to the project. For your convenience, I'm going to list them in the same order as the
Files changedtab shows:.editorconfigPHP files wildcard pattern and apply the rules to all the PHP files (mostly a new line at the end of a file).editoconfigrules to other files (including.ymland.jsonfiles)build.ymlworkflow switch toubuntu-latestbuild.ymlworkflow add support for new PHP (8.2, 8.3) and PHPUnit (10, 11) versions.gitignoreadd new exclusions (includingcomposer.lock- explanation in the next improvement)composer.lockfile from the project (it is not recommended to store it in the repo for libraries)composer requireis more common)https://prefix)composer.jsonmove the Tests namespace to the development environmentcomposer.jsonadd a scripts section (it allows running tests through the composer, very convenient)If this PR is too big, I can try to divide it into three smaller ones. @isidore let me please know, if you need any help with this PR.