Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strlcpy.c and strlcat.c #656

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Update strlcpy.c and strlcat.c #656

merged 2 commits into from
Apr 25, 2021

Conversation

guijan
Copy link
Contributor

@guijan guijan commented Apr 9, 2021

The other BSD functions in the /lib directory are outdated too but I'm not familiar with them and I haven't checked if there are any breaking changes to their interfaces.

Additionally, have you considered the libbsd library? It's a popular library so it's on pretty much every distro repo and it runs on Linux, Mac, and it doesn't run on Windows but there Cygwin provides BSD functions instead and Microsoft's WSL is just Ubuntu as far as we're concerned.

The library provides all the BSD extensions in the /lib directory of tcpreplay's source tree and many more, it also has an "overlay" mode that introduces the functions in the same standard headers that the BSDs extend, and if the libc it was compiled for implements the functions it doesn't include them. Cygwin also provides the BSD functions in the standard headers, so portability is only a matter of depending on the library on Linux, WSL, and Mac.

@guijan guijan changed the title Update a few Update strlcpy.c and strlcat.c Apr 9, 2021
@fklassen
Copy link
Member

Thanks for the PRs. Will consider libbsd as a future enhancement.

@fklassen fklassen merged commit 6a5662a into appneta:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants