Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added M-Code Variant for Fanuc i-Series Controls #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

doggt123
Copy link

@doggt123 doggt123 commented Dec 22, 2022

Pull Request

Description

Due to the multi-chuck and live tooling nature of these lathes they have unique M and G codes that aren't shared with most other lathes. I've gone ahead and added all the common M codes we use in our shop with these machines. I have begun work on the G code variant list, but it is incomplete currently.

Issues

Reviewer Notes

This is my first time contributing to a github project, I believe I've done everything correctly but apologies if something was missed.

Checklist

  • I have followed the guidelines in the Contributing document.
  • I have followed the Code of Conduct for this project.
  • My changes follow the coding style of this project.
  • I have run npm run test-all and it completed without errors.
  • My changes have been formatted and linted.
  • I have made any relevant changes to the documentation as needed (include CHANGELOG.md and/or README.md).
  • My changes have a descriptive commit message with a short title, including links to issues it addresses.
  • I had fun.

controllers, began G code list but unfinished currently.
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

@mikecentola mikecentola added variant Variant added or updated and removed stale-pull-request labels Apr 25, 2023
@mikecentola
Copy link
Member

Thanks! I'll look into this and we can merge it in when its finished if need be.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-pull-request variant Variant added or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants