Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: guard against reconciliations job encountering empty arrays #49

Merged
merged 3 commits into from
Apr 22, 2023
Merged

fix: guard against reconciliations job encountering empty arrays #49

merged 3 commits into from
Apr 22, 2023

Conversation

jcace
Copy link
Contributor

@jcace jcace commented Apr 22, 2023

closes #48

@jcace jcace requested a review from alvin-reyes April 22, 2023 03:05
@jcace jcace marked this pull request as ready for review April 22, 2023 03:05
alvin-reyes
alvin-reyes approved these changes Apr 22, 2023
View reviewed changes
Copy link

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcace jcace merged commit 4f144ae into main Apr 22, 2023
@jcace jcace deleted the fix.reconciliationCrash branch April 22, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes alvin-reyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Crash after creating a lot of replications
2 participants
@jcace @alvin-reyes