Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the camera controller to use the project's camera or a given one #2112

Merged
merged 2 commits into from
Jul 6, 2018

Conversation

oktomus
Copy link
Member

@oktomus oktomus commented Jul 6, 2018

This fixes crashes occurring in interactive mode while editing the
camera.

This fixes crashes occuring in interactive mode while editing the
camera.
@oktomus oktomus requested a review from dictoon July 6, 2018 08:30
Copy link
Member

@dictoon dictoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

The only thing I'm wondering is whether we could get rid of m_custom_camera_enabled and simply check if m_custom_camera is set or not.

@oktomus
Copy link
Member Author

oktomus commented Jul 6, 2018

But what if we set a camera and the pointer is no longer valid ? The controller will use the project's camera. I don't know if that could happen or not... What do you think ?

@dictoon dictoon merged commit 08408ff into appleseedhq:master Jul 6, 2018
@oktomus oktomus deleted the fix-camera-update-crash branch July 10, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants