Minor fix on save extra AOVs (originally #1865) #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dictoon
reviewed
Mar 4, 2018
| @@ -706,7 +706,7 @@ namespace | |||
| { | |||
| bool success = true; | |||
|
|
|||
| if (extension != ".exr") | |||
| if (extension != ".exr" && extension != ".EXR") | |||
There was a problem hiding this comment.
That's not robust enough (wouldn't work with ".Exr" for instance). I suggest converting the extension to lower case before doing the check.
There was a problem hiding this comment.
Ok, then we should also do that in write_image
There was a problem hiding this comment.
It's already properly done in write_image():
string extension = lower_case(bf_file_path.extension().string());
There was a problem hiding this comment.
That said, the problem appears to also exist in write_main_image(), maybe that's what you meant.
There was a problem hiding this comment.
No it wasn't, I haven't seen the lower_case code. But thanks for pointing out this, I will fix that
dictoon
approved these changes
Mar 5, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1865