Rename ExtensionImportVisibility to MemberImportVisibility and fix bugs #73063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
rename-extension-import-visibility-feature
branch
from
e6c75ca to
d875291
Compare
This feature controls lookup behavior for members in general, not just extension members. Resolves rdar://126491324
- Reorganize test cases - Add tests cases for multi-file and contextual base lookup - Verify behavior without `MemberImportVisibility` feature NFC.
Make sure suggested imports are consistent with imports in other files. Also, make sure the underlying clang module is always imported `@_exported`.
This results in clearer source locations for diagnostics.
tshortli
force-pushed
the
rename-extension-import-visibility-feature
branch
from
d875291 to
865c26c
Compare
|
@swift-ci please smoke test |
tshortli
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
xymus
reviewed
Apr 17, 2024
| @@ -167,9 +167,9 @@ ERROR(init_candidate_inaccessible,none, | |||
|
|
|||
| ERROR(candidate_from_missing_import,none, | |||
| "%0 %1 is not available due to missing import of defining module %2", | |||
There was a problem hiding this comment.
General comment as this wasn't introduced in this PR. Should we try to avoid available here as it points to the availability system, maybe reachable or visible?
There was a problem hiding this comment.
Yeah, that's good feedback. Perhaps we should use the word "inaccessible" which would match the wording of diagnostics about declarations that are unavailable due to access levels.
There was a problem hiding this comment.
I expect to continue refining this implementation, so I'll track this as something to re-evaluate in the next PR.
There was a problem hiding this comment.
Yeah, this should not block this PR. And "inaccessible" sounds good to me.
xymus
approved these changes
Apr 17, 2024
DougGregor
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
ExtensionImportVisibilityexperimental feature introduced in #72060 toMemberImportVisibility. Although extension members are the members that are most often accidentally visible via transitive imports, the effects of enabling the feature are not limited to lookup of members on extensions. The test cases added in this PR provide examples of additional situations where these diagnostics will take effect.In addition to renaming the experimental feature, this PR also refines the implementation, increases test coverage, and fixes a couple of bugs:
@_implementationOnlyor@_exported) are now prepended to theimport Modulefix-it.Resolves rdar://126491324 and #46493.