Swap availability for #if check on Float16. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentey
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Looks good to me! (I'd probably leave the macOS availability annotations in.)
We really need some sort of compile-time way to check the version of the stdlib. We could have Package.swift do an if #available macOS(11.0) check and set a HAVE_FLOAT16 compile-time conditional based on that, but that seems a bit too fancy.
|
@lorentey yeah, step 2 here is definitely to figure out how to avoid this mess in the future =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 12 on Catalina has Swift 5.3 but the macOS 10.15 SDK, which breaks the conditionals around Float16. Since the type is unconditionally unavailable on macOS, we can simply
#if-out any Float16 extensions instead.