fix Swift 5 warnings (mostly redundant modifiers) #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
changed the title
|
spurious fail |
|
@swift-nio-bot test this please |
|
Ugh I hate this warning too. What does it achieve beyond forcing people to put the access modifier doc page in their bookmarks? |
Lukasa
requested changes
Oct 30, 2018
| @@ -54,7 +54,7 @@ public extension ChannelPipeline { | |||
| /// complete. | |||
| /// - returns: An `EventLoopFuture` that will fire when the pipeline is configured. | |||
| @available(*, deprecated, message: "Please use configureHTTPServerPipeline") | |||
| public func addHTTPServerHandlersWithUpgrader(first: Bool = false, | |||
| func addHTTPServerHandlersWithUpgrader(first: Bool = false, | |||
| upgraders: [HTTPProtocolUpgrader], | |||
| _ upgradeCompletionHandler: @escaping (ChannelHandlerContext) -> Void) -> EventLoopFuture<Void> { | |||
There was a problem hiding this comment.
Mind fixing up the indentation?
| @@ -93,7 +93,7 @@ public extension ChannelPipeline { | |||
| /// failure to parse the HTTP request) by sending 400 errors. Defaults to `false` for | |||
| /// backward-compatibility reasons. | |||
| /// - returns: An `EventLoopFuture` that will fire when the pipeline is configured. | |||
| public func configureHTTPServerPipeline(first: Bool = false, | |||
| func configureHTTPServerPipeline(first: Bool = false, | |||
| withPipeliningAssistance pipelining: Bool = true, | |||
| withServerUpgrade upgrade: HTTPUpgradeConfiguration? = nil, | |||
| withErrorHandling errorHandling: Bool = false) -> EventLoopFuture<Void> { | |||
There was a problem hiding this comment.
Indentation here too please.
weissi
force-pushed
the
jw-swift5-warnings
branch
from
8632831
to
2ef0ced
Compare
Motivation:
Swift 5 complains on redundant modifiers. For example declaring a
`public func` inside of a `public extension` is now a warning. I don't
agree with this but I dislike warnings even more, so...
Modifications:
remove all redundant modifiers that the compiler now warns about such as
swift-nio/Sources/NIOPriorityQueue/PriorityQueue.swift:90:5: warning: 'public' modifier is redundant for property declared in a public extension
Result:
no warnings in Swift 5
weissi
force-pushed
the
jw-swift5-warnings
branch
from
2ef0ced
to
587161a
Compare
Lukasa
approved these changes
Oct 30, 2018
|
Seems like you hit a spurious failure again. |
|
@swift-nio-bot test this please |
| defer { | ||
| // fr2's underlying fd must be closed by us. | ||
| XCTAssertNoThrow(try fh2.close()) | ||
| } | ||
|
|
||
| XCTAssertEqual(Array("01234".utf8), fr1Bytes) |
There was a problem hiding this comment.
@weissi any reason why this was moved ?
There was a problem hiding this comment.
@normanmaurer yes, previously it didn't actually do anything in case of an error thrown. defers are only executed on errors if the defer is syntactically before the error thrown. So generally cleanup-defers need to go straight after the resource creation.
The previous one raised a warning in Swift 5
normanmaurer
approved these changes
Oct 30, 2018
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift 5 complains on redundant modifiers. For example declaring a
public funcinside of apublic extensionis now a warning. I don'tagree with this but I dislike warnings even more, so...
Modifications:
remove all redundant modifiers that the compiler now warns about such as
Result:
no warnings in Swift 5