Adds Swift Concurrency Availability to macOS 10.15, iOS 13, tvOS 13, and watchOS 6 #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
3 tasks
Lukasa
reviewed
Dec 3, 2021
auto-merge was automatically disabled
December 3, 2021 16:23
Head branch was pushed to by a user without write access
|
@swift-nio-bot test this please |
Lukasa
approved these changes
Dec 3, 2021
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Swift Concurrency Availability to macOS 10.15, iOS 13, tvOS 13, and watchOS 6
Motivation:
This PR is related to #2000.
With the support for Swift Concurrency coming to macOS 10.15, iOS 13, tvOS 13, and watchOS 6 with Xcode 13.2, the Swift Concurrency features should be available when compiling for these targets using Xcode 13.2.
Modifications:
Change the @available annotations to macOS 10.15, iOS 13, tvOS 13, and watchOS 6 and introduce a temporary code duplication as discussed in #2000.
Changes the source code of the NIOAsyncAwaitDemo to only work on Swift 5.2.2 (Xcode 13.2) on macOS 10.15 and newer and all other non-Darwin platforms.
Result:
The Swift Concurrency features are marked with
@available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *)and can therefore be used on macOS 10.15, iOS 13, tvOS 13, and watchOS 6.