Skip to content

Commit

Permalink
[CI] Small adjustments to the Windows actions (#2939)
Browse files Browse the repository at this point in the history
# Motivation

There were two small problems:
1. The CI for the nightlies wasn't properly skipped
2. The name for the matrix wasn't applied in the case where it was
skipped

# Modification

This PR hopefully fixes both issues.
  • Loading branch information
FranzBusch authored Oct 22, 2024
1 parent ff6dea9 commit ecbb5ea
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/swift_matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ jobs:
windows:
name: Windows (${{ matrix.swift.swift_version }})
runs-on: windows-2022
if: ${{ inputs.matrix_windows_6_0_enabled }}
strategy:
fail-fast: false
matrix:
Expand All @@ -160,6 +159,7 @@ jobs:
- image: swift:6.0-windowsservercore-ltsc2022
swift_version: "6.0"
enabled: ${{ inputs.matrix_windows_6_0_enabled }}
if: ${{ inputs.matrix_windows_6_0_enabled }}
steps:
- name: Pull Docker image
if: ${{ matrix.swift.enabled }}
Expand All @@ -180,7 +180,6 @@ jobs:
windows-nightly:
name: Windows (${{ matrix.swift.swift_version }})
runs-on: windows-2019
if: ${{ inputs.matrix_windows_nightly_6_0_enabled }} && ${{ inputs.matrix_windows_nightly_main_enabled }}
strategy:
fail-fast: false
matrix:
Expand All @@ -192,6 +191,7 @@ jobs:
- image: swiftlang/swift:nightly-main-windowsservercore-1809
swift_version: "nightly-main"
enabled: ${{ inputs.matrix_windows_nightly_main_enabled }}
if: ${{ inputs.matrix_windows_nightly_6_0_enabled }} || ${{ inputs.matrix_windows_nightly_main_enabled }}
steps:
- name: Pull Docker image
if: ${{ matrix.swift.enabled }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
matrix_linux_nightly_6_0_command_override: "swift test ${{ inputs.linux_nightly_6_0_arguments_override }}"
matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }}
matrix_linux_nightly_main_command_override: "swift test ${{ inputs.linux_nightly_main_arguments_override }}"
matrix_windows_command: "swift test"
matrix_windows_6_0_enabled: ${{ inputs.windows_6_0_enabled }}
matrix_windows_6_0_command_override: "swift test ${{ inputs.windows_6_0_arguments_override }}"
matrix_windows_nightly_6_0_enabled: ${{ inputs.windows_nightly_6_0_enabled }}
Expand Down

0 comments on commit ecbb5ea

Please sign in to comment.