-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Swift 5.5 #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Si Beaumont <beaumont@apple.com>
Lukasa
reviewed
Apr 14, 2023
glbrntt
reviewed
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo one nit
Signed-off-by: Si Beaumont <beaumont@apple.com>
Lukasa
approved these changes
Apr 14, 2023
@swift-server-bot add to allowlist |
glbrntt
approved these changes
Apr 14, 2023
@yim-lee Please can we remove the 5.5 CI for this project? |
@simonjbeaumont Done |
dnadoba
added
🔨 semver/patch
No public API change.
🆕 semver/minor
Adds new public API.
and removed
🆕 semver/minor
Adds new public API.
🔨 semver/patch
No public API change.
labels
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now Swift 5.8 is released, we are dropping support for 5.5, in line with the usual support window.
Modifications:
Package@swift-5.5.swift
.#if swift(>=5.6)
compiler guards.Result:
No functional change, but Swift 5.5 is no longer supported.