Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use #fileID/#filePath instead of #file #164

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Use #fileID/#filePath instead of #file #164

merged 2 commits into from
Oct 31, 2022

Conversation

carolinacass
Copy link
Contributor

Motivation:

#fileID introduced in Swift 5.3, so no longer need to use #file anywhere

Modifications:

Changed #file to #filePath because of XCT Assertions

@carolinacass
Use #fileID/#filePath instead of #file
d49ff5a 
Motivation:

Modifications:

Changed #file to #filePath or #fileID depending on situation
\
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Oct 28, 2022
@glbrntt glbrntt merged commit d3345ff into apple:main Oct 31, 2022
@glbrntt glbrntt added semver/none No version bump required. and removed 🔨 semver/patch No public API change. labels Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolinacass @glbrntt