Add Sendable annotations to new async APIs
#427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation We just released our new async APIs but forgot to mark the new types as `Sendable`. This is causing warnings for users and we should properly mark them as `Sendable` since we expect users to use them from concurrent contexts. # Modification Adding `Sendable` to the `NIONegotiatedHTTPVersion` was pretty straight forward; however, adding `Sendable` to `AsyncStreamMultiplexer` was a bit more complicated since it stored the `InlineStreamMultiplexer` which we cannot easily make `Sendable`. Hence, we are now holding the `InlineStreamMultiplexer` in a `NIOLoopBound` and are submitting the work to the correct `EventLoop` before we call the underlying multiplexer. # Result No more `Sendable` warnings for our users.
|
Let's close this in favour of @rnro PR then and work on the lense type a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We just released our new async APIs but forgot to mark the new types as
Sendable. This is causing warnings for users and we should properly mark them asSendablesince we expect users to use them from concurrent contexts.Modification
Adding
Sendableto theNIONegotiatedHTTPVersionwas pretty straight forward; however, addingSendabletoAsyncStreamMultiplexerwas a bit more complicated since it stored theInlineStreamMultiplexerwhich we cannot easily makeSendable. Hence, we are now holding theInlineStreamMultiplexerin aNIOLoopBoundand are submitting the work to the correctEventLoopbefore we call the underlying multiplexer.Result
No more
Sendablewarnings for our users.