-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve HTTPHeader normalisation performance for large inputs #347
Merged
Lukasa
merged 1 commit into
apple:main
from
glbrntt:gb-improve-header-normalisation-perf
May 17, 2022
Merged
Improve HTTPHeader normalisation performance for large inputs #347
Lukasa
merged 1 commit into
apple:main
from
glbrntt:gb-improve-header-normalisation-perf
May 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Header normalisation is expensive when the input headers contain a large number of connection header values. Modifications: - When the headers to normalise contain more than 32 connection header values use a set to provide constant time lookup, rather than linear. Result: Better perf for HTTPHeader normalisation with large connection header value lists.
@swift-nio-bot test perf please |
performance reportbuild id: 21 timestamp: Tue May 17 09:43:08 UTC 2022 results
comparison
significant differences found |
Lukasa
approved these changes
May 17, 2022
Really nice change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Header normalisation is expensive when the input headers contain a large
number of connection header values.
Modifications:
values use a set to provide constant time lookup, rather than linear.
Result:
Better perf for HTTPHeader normalisation with large connection header
value lists.