Ignore empty values when returning canonical form of header values #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Sep 29, 2021
Lukasa
reviewed
Sep 29, 2021
Motivation: The return value from `HPACKHeaders.subscript(canonicalForm:)` is inconsistent with respect to returning empty strings. If a value for a header field is an empty string then the canonical form will not return that empty string. However, if a value is a string containing only whitespace then an empty string will be returned. Modifications: - Filter out empty substrings after trimming whitespace - Add a test Result: - `HPACKHeaders.subscript(canonicalForm:)` does not produce empty strings
glbrntt
force-pushed
the
gb-no-empty-strings-for-canonical-form
branch
from
bd32469 to
d402ae8
Compare
Lukasa
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The return value from
HPACKHeaders.subscript(canonicalForm:)isinconsistent with respect to returning empty strings.
If a value for a header field is an empty string then the canonical form
will not return that empty string. However, if a value is a string
containing only whitespace then an empty string will be returned.
Modifications:
Result:
HPACKHeaders.subscript(canonicalForm:)does not produce empty strings