Don't count CR or LF as whitespace when trimming whitespace from header values #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er values Motivation: The OWS rule from the HTTP semantics draft only considers 'SP' and 'HTAB' to be whitespace. We also (unnecessarily) consider CR and LF to be whitespace. Modifications: - Remove CR and LF from the characters we consider to be whitespace - Update tests Result: We no longer consider CR or LF to be whitespace when trimming whitespace when producing the canonical form of header values.
Lukasa
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The OWS rule from the HTTP semantics draft only considers 'SP' and
'HTAB' to be whitespace. We also (unnecessarily) consider CR and LF to
be whitespace.
Modifications:
Result:
We no longer consider CR or LF to be whitespace when trimming
whitespace when producing the canonical form of header values.