-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Install libraries in standard directories #446
[cmake] Install libraries in standard directories #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me! Will this change affect builds of swift-collections that are part of Swift toolchains?
Oh, could you please target this change on the release/1.2
branch rather main
? I expect we'll want to quickly ship this.
Ah sorry, I opened it as a draft PR because I am waiting for a review on apple/swift-argument-parser#685, which does the same thing but in |
Previously, libs were installed under `lib/swift/${os}`. They should be installed in the default library directory for the relevant target system. In addition, swiftmodules were installed in the older layout format. This changes to use the standard modern layout format for swiftmodules.
7c716d0
to
e0021fb
Compare
apple/swift-argument-parser#685 has landed. This is bringing the same changes to this repository. I changed the base branch to |
This also reverts 40adeb7, which seems to have been done in error.
I pushed an update that reverts commit 40adeb7, it seems to have been done in error. Other Swift libraries put the |
This was changed in apple/swift-collections#446.
This was changed in apple/swift-collections#446.
You don't need to do anything else -- the changes will get picked up the next time we merge things forward. (This is a manual process, so there can be a delay. But this repo's |
Previously, libs were installed under
lib/swift/${os}
. They should be installed in the default library directory for the relevant target system.In addition, swiftmodules were installed in the older layout format. This changes to use the standard modern layout format for swiftmodules.
Checklist