build: simplify build rules (NFC) #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift currently requires 3.19.x to build. Bump the CMake minimum version to 3.19 to allow us to remove some workarounds from earlier releases.
|
@swift-server-bot please test |
|
I'm gonna let Yim tackle this one. |
|
@swift-server-bot test this please |
|
@compnerd Is this change required (i.e., we need to cut a release and modify update-checkout) for merging swiftlang/swift-package-manager#7119 or they are independent of each other? Also, do we need similar change in swift-asn1 and swift-crypto? |
|
@yim-lee I don't think that we need an immediate release for this. I will be uploading similar patches for the ASN1 and Crypto repositories (if I have not already). I am trying to just clean up some of the builds and enable easier building/debugging LSP. |
|
OK. Thanks @compnerd! |
yim-lee
approved these changes
Nov 28, 2023
Lukasa
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift currently requires 3.19.x to build. Bump the CMake minimum version to 3.19 to allow us to remove some workarounds from earlier releases.