Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Expanded CMS Support #151

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add Expanded CMS Support #151

merged 1 commit into from
Oct 25, 2023

Conversation

davidzech
Copy link
Contributor

  • Support BER Encoded CMS
  • Support Attached CMS
  • Support Signed Attributes CMS

davidzech
davidzech commented Oct 18, 2023
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
@davidzech
Copy link
Contributor Author

Leaving this in draft until apple/swift-asn1 is tagged with a new version with BER support.

@dnadoba
Copy link
Member

dnadoba commented Oct 23, 2023

@davidzech we have just released Swift ASN.1 1.1.0

@davidzech davidzech marked this pull request as ready for review October 24, 2023 06:49
@davidzech
Copy link
Contributor Author

@davidzech we have just released Swift ASN.1 1.1.0

Ack. Updated and removed Draft status @dnadoba

@Lukasa
Copy link
Contributor

Lukasa commented Oct 24, 2023

@swift-server-bot add to allowlist

@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Oct 24, 2023
@Lukasa
Copy link
Contributor

Lukasa commented Oct 24, 2023

Based on CI, you need to add this block to your new files that import Foundation:

#if canImport(Darwin)
import Foundation
#else
@preconcurrency import Foundation
#endif

@davidzech
Copy link
Contributor Author

Based on CI, you need to add this block to your new files that import Foundation:

#if canImport(Darwin)
import Foundation
#else
@preconcurrency import Foundation
#endif

Ack. I likely need to update CMake again too.

@davidzech
Add Expanded CMS Support
936f0e4 
* Support BER Encoded CMS
* Support Attached CMS
* Support Signed Attributes CMS
Lukasa
Lukasa approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API breakage is acceptable here.

@Lukasa Lukasa merged commit 5afc921 into apple:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidzech @dnadoba @Lukasa