Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore groovy SE_NO_SERIALVERSIONID SpotBugs warning #995

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

Scottmitch
Copy link
Member

No description provided.

Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, spotbugs should be disabled for servicetalk-gradle-plugin-internal:

// Ignore Spotbugs for this module
spotbugs {
ignoreFailures = true
showProgress = false
}

If you are investigating issues with spotbug, consider updating the plugin to the latest 4.0.5 version.

@Scottmitch
Copy link
Member Author

spotbugs version update: #997

good point on the ignoreFailures ... however it still reduces noise to ignore the failures.

@Scottmitch Scottmitch merged commit 0a1eddd into apple:master Apr 2, 2020
@Scottmitch Scottmitch deleted the groovy_checkstyle branch April 2, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants