gRPC gradle plugin rework #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
force-pushed
the
grpc_plugin_deps
branch
from
3e72295 to
0cb7da2
Compare
Scottmitch
commented
Mar 25, 2020
| File scriptExecutableFile | ||
| try { | ||
| if (org.gradle.internal.os.OperatingSystem.current().isWindows()) { | ||
| scriptExecutableFile = File.createTempFile(scriptNamePrefix, ".bat") |
There was a problem hiding this comment.
generation of temp files is not ideal ... but a reliable way to make sure we use the jar file that is actually resolved for each build. I'm open to alternatives @idelpivnitskiy
There was a problem hiding this comment.
how grpc-java solves this issue?
There was a problem hiding this comment.
they don't have to deal with this because they write their plugin in c++ and publish a single executable for each platform.
Scottmitch
force-pushed
the
grpc_plugin_deps
branch
from
0cb7da2 to
bf58a81
Compare
...gradle-plugin/src/main/groovy/io/servicetalk/grpc/gradle/plugin/ServiceTalkGrpcPlugin.groovy
Outdated
Show resolved
Hide resolved
...gradle-plugin/src/main/groovy/io/servicetalk/grpc/gradle/plugin/ServiceTalkGrpcPlugin.groovy
Outdated
Show resolved
Hide resolved
| File scriptExecutableFile | ||
| try { | ||
| if (org.gradle.internal.os.OperatingSystem.current().isWindows()) { | ||
| scriptExecutableFile = File.createTempFile(scriptNamePrefix, ".bat") |
There was a problem hiding this comment.
how grpc-java solves this issue?
|
build failure attributed to #744 |
|
@servicetalk-bot test this please |
Motivation: 0ebe48e divided the servicetalk-grpc-gradle plugin into two files: 1. an executable script 2. an uber jar with the plugin logic The executable script assumed the uber jar would be co-located in the same directory as the uber jar, but that isn't the case in gradle caches. This means the plugin may fail to execute outside of the maven m2 repository structure. Modifications: - Instead of publishing a static script for each platform which assumes a co-located uber jar, dynamically generate the executable script depending upon where the uber jar is resolved from for the local build. Result: servicetalk-grpc-gradle works with gradle cache directory structure and local development.
Scottmitch
force-pushed
the
grpc_plugin_deps
branch
from
30b4f2c to
5cceef5
Compare
|
another failure attributed to #744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
0ebe48e divided the
servicetalk-grpc-gradle plugin into two files:
The executable script assumed the uber jar would be co-located in the
same directory as the uber jar, but that isn't the case in gradle
caches. This means the plugin may fail to execute outside of the maven
m2 repository structure.
Modifications:
a co-located uber jar, dynamically generate the executable script
depending upon where the uber jar is resolved from for the local build.
Result:
servicetalk-grpc-gradle works with gradle cache directory structure and
local development.