Don't re-use *Exceptions when stored in static fields if enableSuppre… #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@normanmaurer Same test:
failed for both PRBs, looks like something isn't happy 😢 |
|
@NiteshKant will check |
normanmaurer
force-pushed
the
no_static_exception
branch
from
05fce96 to
49ef379
Compare
|
@normanmaurer JDK 11 build failure is due to a known flaky test: Can you add this failure details to the issue? |
NiteshKant
approved these changes
Mar 6, 2020
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/RepeatStrategies.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/servicetalk/transport/netty/internal/StacklessClosedChannelException.java
Show resolved
Hide resolved
…ssion can not be set to false Motivation: Have a static instance of an Exception which does not set enableSuppression to false when constructed is considered to be dangerous as it may escape to the user where an user may add more exceptions to it. The problem with this is that the internal storage will grow and grow over time and never be GC'ed. This can lead to OOME situations. Modifications: Create new *Exceptions when needed and remove usage of static stored *Exceptions if needed. Result: No more risk of OOME due user calling `addSuppressed` on exceptions that are propagated through the code
…rent/api/RepeatStrategies.java Update comment Co-Authored-By: Nitesh Kant <nitesh_kant@apple.com>
normanmaurer
force-pushed
the
no_static_exception
branch
from
2e11bb8 to
72191ba
Compare
|
Merged... thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssion can not be set to false
Motivation:
Have a static instance of an Exception which does not set enableSuppression to false when constructed is considered to be dangerous as it may escape to the user where an user may add more exceptions to it. The problem with this is that the internal storage will grow and grow over time and never be GC'ed. This can lead to OOME situations.
Modifications:
Create new *Exceptions when needed and remove usage of static stored *Exceptions if needed.
Result:
No more risk of OOME due user calling
addSuppressedon exceptions that are propagated through the code