concurrent-api: shave some allocations from new Scope #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In the allocation profile we see anonymous instances of the new Scope being created. While not a big deal, we can do better. Modifications: We can shave these off of the default implementation by making CopyOnWriteContextMap, and really any context map, an instance of Scope. The close() method just needs to then ask the current provider to set the context to itself. Result: Less allocations.
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ScopeContextMap.java
Outdated
Show resolved
Hide resolved
| * Set the current {@link ContextMap} | ||
| * @param contextMap the {@link ContextMap} to set in the thread local state. | ||
| */ | ||
| void setContextMap(ContextMap contextMap); |
There was a problem hiding this comment.
Then it looks more like ContextMapHolder, should we just make this interface extend the holder?
There was a problem hiding this comment.
I did do it, but it's a bit itchy due to the @Nullable annotations and the return type of .context(ContextMap).
...-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultAsyncContextProvider.java
Show resolved
Hide resolved
...icetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/AsyncContextProvider.java
Outdated
Show resolved
Hide resolved
bryce-anderson
commented
Feb 6, 2025
...icetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/AsyncContextProvider.java
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Feb 6, 2025
...-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultAsyncContextProvider.java
Show resolved
Hide resolved
...-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultAsyncContextProvider.java
Show resolved
Hide resolved
bryce-anderson
added a commit
to bryce-anderson/servicetalk
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In the allocation profile we see anonymous instances of the new Scope being created. While not a big deal, we can do better.
Modifications:
We can shave these off of the default implementation by making CopyOnWriteContextMap, and really any context map, an instance of Scope. The close() method just needs to then ask the current provider to set the context to itself.
Result:
Less allocations.