Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused api dependencies or move them to lower scope #3169

Merged
merged 1 commit into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions servicetalk-data-protobuf/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@ ideaModule.dependsOn "generateTestProto"

dependencies {
api platform("com.google.protobuf:protobuf-bom:$protobufVersion")
api project(":servicetalk-buffer-api")
api project(":servicetalk-concurrent-api")
api project(":servicetalk-serialization-api")
api project(":servicetalk-serializer-api")
api "com.google.protobuf:protobuf-java"

implementation project(":servicetalk-annotations")
implementation project(":servicetalk-buffer-api")
implementation project(":servicetalk-serializer-utils")

testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version")
testImplementation project(":servicetalk-test-resources")
testImplementation project(":servicetalk-buffer-netty")
testImplementation project(":servicetalk-concurrent-api")
testImplementation project(":servicetalk-test-resources")
testImplementation "org.junit.jupiter:junit-jupiter-api"
testImplementation "org.junit.jupiter:junit-jupiter-params"
testImplementation "org.hamcrest:hamcrest:$hamcrestVersion"
Expand Down
2 changes: 1 addition & 1 deletion servicetalk-grpc-netty/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ afterEvaluate {
dependencies {
api project(":servicetalk-client-api")
api project(":servicetalk-grpc-api")
api project(":servicetalk-grpc-utils")
api project(":servicetalk-http-netty")
api project(":servicetalk-transport-api")

Expand Down Expand Up @@ -79,6 +78,7 @@ dependencies {
testImplementation project(":servicetalk-encoding-netty")
testImplementation project(":servicetalk-grpc-protobuf")
testImplementation project(":servicetalk-grpc-protoc")
testImplementation project(":servicetalk-grpc-utils")
testImplementation project(":servicetalk-http-utils")
testImplementation project(":servicetalk-logging-api")
testImplementation project(":servicetalk-router-api")
Expand Down
1 change: 0 additions & 1 deletion servicetalk-grpc-protobuf/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ dependencies {
api project(":servicetalk-encoding-api")
api project(":servicetalk-grpc-api")
api "com.google.protobuf:protobuf-java"
api "com.google.api.grpc:proto-google-common-protos:$protoGoogleCommonProtosVersion"

implementation project(":servicetalk-annotations")
implementation project(":servicetalk-buffer-api")
Expand Down
15 changes: 13 additions & 2 deletions servicetalk-grpc-protoc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,20 @@ plugins {

apply plugin: "io.servicetalk.servicetalk-gradle-plugin-internal-library"

afterEvaluate {
if (tasks.findByName("projectHealth")) {
dependencyAnalysis {
issues {
onIncorrectConfiguration {
exclude(":servicetalk-data-protobuf") // Needed for the generated classes
}
}
}
}
}

dependencies {
// Needed for the generated classes
api project(":servicetalk-data-protobuf")
api project(":servicetalk-data-protobuf") // Needed for the generated classes

compileOnly "com.squareup:javapoet:$javaPoetVersion"

Expand Down
1 change: 0 additions & 1 deletion servicetalk-opentelemetry-asynccontext/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ apply plugin: "io.servicetalk.servicetalk-gradle-plugin-internal-library"

dependencies {
api platform("io.opentelemetry:opentelemetry-bom:$opentelemetryVersion")
api "io.opentelemetry:opentelemetry-api"
api "io.opentelemetry:opentelemetry-context"

implementation project(":servicetalk-annotations")
Expand Down
1 change: 0 additions & 1 deletion servicetalk-opentelemetry-asynccontext/gradle.lockfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# Manual edits can break the build and are not advised.
# This file is expected to be part of source control.
com.google.code.findbugs:jsr305:3.0.2=compileClasspath,runtimeClasspath
io.opentelemetry:opentelemetry-api:1.38.0=compileClasspath,runtimeClasspath
io.opentelemetry:opentelemetry-bom:1.38.0=compileClasspath,runtimeClasspath
io.opentelemetry:opentelemetry-context:1.38.0=compileClasspath,runtimeClasspath
org.jctools:jctools-core:4.0.3=runtimeClasspath
Expand Down
1 change: 0 additions & 1 deletion servicetalk-opentracing-asynccontext/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
apply plugin: "io.servicetalk.servicetalk-gradle-plugin-internal-library"

dependencies {
api project(":servicetalk-opentracing-inmemory")
api project(":servicetalk-opentracing-inmemory-api")
api "io.opentracing:opentracing-api:$openTracingVersion"

Expand Down
4 changes: 2 additions & 2 deletions servicetalk-tcp-netty-internal/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,19 @@ afterEvaluate {

dependencies {
api platform("io.netty:netty-bom:$nettyVersion")
api project(":servicetalk-client-api")
api project(":servicetalk-concurrent-api")
api project(":servicetalk-logging-api")
api project(":servicetalk-transport-api")
api project(":servicetalk-transport-netty-internal")
api "io.netty:netty-common"
api "io.netty:netty-handler"
api "io.netty:netty-transport"

implementation project(":servicetalk-annotations")
implementation project(":servicetalk-client-api")
implementation project(":servicetalk-concurrent")
implementation project(":servicetalk-concurrent-api-internal")
implementation project(":servicetalk-concurrent-internal")
implementation project(":servicetalk-logging-api")
implementation project(":servicetalk-logging-slf4j-internal")
implementation project(":servicetalk-utils-internal")
implementation "io.netty:netty-buffer"
Expand Down
2 changes: 1 addition & 1 deletion servicetalk-traffic-resilience-http/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ dependencies {
api project(":servicetalk-concurrent-api")
api project(":servicetalk-context-api")
api project(":servicetalk-http-api")
api project(":servicetalk-http-utils")
api project(":servicetalk-transport-api")

implementation project(":servicetalk-annotations")
implementation project(":servicetalk-buffer-api")
implementation project(":servicetalk-concurrent")
implementation project(":servicetalk-concurrent-internal")
implementation project(":servicetalk-http-utils")
implementation project(":servicetalk-utils-internal")
implementation "org.slf4j:slf4j-api:$slf4jVersion"

Expand Down
3 changes: 2 additions & 1 deletion servicetalk-transport-netty-internal/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ afterEvaluate {
dependencies {
api platform("io.netty:netty-bom:$nettyVersion")
api project(":servicetalk-buffer-api")
api project(":servicetalk-buffer-netty")
api project(":servicetalk-concurrent")
api project(":servicetalk-concurrent-api")
api project(":servicetalk-concurrent-api-internal")
Expand All @@ -47,6 +46,7 @@ dependencies {

implementation platform("io.netty:netty-bom:$nettyVersion")
implementation project(":servicetalk-annotations")
implementation project(":servicetalk-buffer-netty")
implementation project(":servicetalk-concurrent-internal")
implementation project(":servicetalk-context-api")
implementation project(":servicetalk-logging-slf4j-internal")
Expand Down Expand Up @@ -96,6 +96,7 @@ dependencies {
testFixturesApi "io.netty:netty-transport"
testFixturesApi "org.junit.jupiter:junit-jupiter-api"

testFixturesImplementation project(":servicetalk-buffer-netty")
testFixturesImplementation project(":servicetalk-utils-internal")
testFixturesImplementation "io.netty.incubator:netty-incubator-transport-classes-io_uring:$nettyIoUringVersion"
testFixturesImplementation "io.netty.incubator:netty-incubator-transport-native-io_uring:$nettyIoUringVersion"
Expand Down
Loading