Preserve full request context while redirecting #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Redirect handling creates new requests, but copies only `HTTP_EXECUTION_STRATEGY_KEY`. As the result, next filters after redirect don't see a state associated with the request flow. Modifications: - Copy full `ContextMap` from each previous request to the next one; Result: Any context information is preserved for all redirected requests, like UUID, counters, execution strategy, etc.
daschl
approved these changes
Nov 14, 2024
bryce-anderson
approved these changes
Nov 14, 2024
|
@daschl I don't have a use-case in mind when ppl won't want some context to propagate forward. Context is local to the app and does not leak over wire. Should be fine to copy all. If there is a use-case, users can always use request transformer to clean some parts of the context they don't want to propagate or if they want to reset something there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Redirect handling creates new requests, but copies only
HTTP_EXECUTION_STRATEGY_KEY. As the result, next filters after redirect don't see a state associated with the request flow.Modifications:
ContextMapfrom each previous request to the next one;Result:
Any context information is preserved for all redirected requests, like UUID, counters, execution strategy, etc.