traffic-resilience-http: Add dry-run mode for resilience filters #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Sometimes people will want to test out the capacity limiters without actually rejecting any traffic. This can help them tune their system and generally just feel more confident. Modifications: Add dry-run mode.
...rc/main/java/io/servicetalk/traffic/resilience/http/AbstractTrafficResilienceHttpFilter.java
Outdated
Show resolved
Hide resolved
.../test/java/io/servicetalk/traffic/resilience/http/TrafficResilienceHttpClientFilterTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/servicetalk/traffic/resilience/http/AbstractTrafficResilienceHttpFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/servicetalk/traffic/resilience/http/AbstractTrafficResilienceHttpFilter.java
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Nov 7, 2024
...rc/main/java/io/servicetalk/traffic/resilience/http/AbstractTrafficResilienceHttpFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/servicetalk/traffic/resilience/http/AbstractTrafficResilienceHttpFilter.java
Outdated
Show resolved
Hide resolved
bryce-anderson
added a commit
to bryce-anderson/servicetalk
that referenced
this pull request
Nov 7, 2024
…ment Motivation: We accidentially removed the discardEventsAfterCancel flag in PR apple#3085. Modifications: Add it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes people will want to test out the capacity limiters without
actually rejecting any traffic. This can help them tune their system
and generally just feel more confident.
Modifications:
Add dry-run mode.