DefaultHostAndPort: equals and hashCode are not consistent
#2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If two instances of `DefaultHostAndPort` are created with hostname in different case, they pass `equals` check but don't have a consistent `hashCode`. As a result, users can't query a `Map` entry with keys in different case. Side-effect of that is a multi-address http client that may have multiple instances of a single-address client for the same hostname in different cases, preventing it from reusing connections. Modifications: - Implement `DefaultHostAndPort.hashCode()` in a consistent way with `InetSocketAddressHolder` where `hostName` hash is computed in case-insensitive mode. - Re-generate `DefaultHostAndPort.equals(...)` implementation to allow a check by reference. - Enhance `DefaultMultiAddressUrlHttpClientBuilderTest` to demonstrate that the problem went away. Result: 1. `DefaultHostAndPort` can be used as a case-insensitive key for maps, matching definition of the host name in URL. 2. Multi-address client correctly recognizes the same host name in case-insensitive way.
bryce-anderson
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If two instances of
DefaultHostAndPortare created with hostname in different case, they passequalscheck but don't have a consistenthashCode. As a result, users can't query aMapentry with keys in different case.Side-effect of that is a multi-address http client that may have multiple instances of a single-address client for the same hostname in different cases, preventing it from reusing connections.
Modifications:
DefaultHostAndPort.hashCode()in a consistent way withInetSocketAddressHolderwherehostNamehash is computed in case-insensitive mode.DefaultHostAndPort.equals(...)implementation to allow a check by reference.DefaultMultiAddressUrlHttpClientBuilderTestto demonstrate that the problem went away.Result:
DefaultHostAndPortcan be used as a case-insensitive key for maps, matching definition of the host name in URL.