Multi-address client: don't leak full request target in exception msg #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Request target may contain sensitive information, like secret query parameters or tokens in path. We should not include it as-is when `MalformedURLException` is thrown. Modifications: - Change how `MalformedURLException` is generated to include only small substring of the request target in the exception message. Result: No risk to leak sensitive data in exception logs.
idelpivnitskiy
force-pushed
the
address-leak
branch
from
3c35600 to
6491807
Compare
daschl
reviewed
Jun 17, 2024
| final String name, | ||
| final String requestTarget) throws MalformedURLException { | ||
| if (value == null) { | ||
| // 8 characters should be enough to give users an idea of what's wrong with the passed URL without |
There was a problem hiding this comment.
Since we are only checking for scheme and host, what about omitting the path completely as part of the error? (understood that it could make it harder to figure out from the logs which request is affected .. but if the scheme is null at least they should have a host to look at).. if the host is null the code path might also be obvious-ish, since we have the call stack in the exception?
daschl
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Request target may contain sensitive information, like secret query parameters or tokens in path. We should not include it as-is when
MalformedURLExceptionis thrown.Modifications:
MalformedURLExceptionis generated to include only small substring of the request target in the exception message.Result:
No risk to leak sensitive data in exception logs.