loadbalancer-experimental: thread through the ConnectionPoolStrategyFactory #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actory Motivation: We have a type ConnectionPoolStrategyFactory that is using the `targetResource` name for observability, contrary to the rest of the DefaultLoadBalancer which is using `lbDescription`. This happens because we accept a fully materialized ConnectionPoolStrategy in the DefaultLoadBalancer constructor instead of a factory like most everything else. Modifications: - Thread through the factory into the DefaultLoadBalancer constructor. - Fix the parameter names to reflect that it's now lbDescription being used.
bryce-anderson
changed the title
idelpivnitskiy
approved these changes
Jun 14, 2024
bryce-anderson
added a commit
to bryce-anderson/servicetalk
that referenced
this pull request
Jun 14, 2024
…actory (apple#2969) Motivation: We have a type ConnectionPoolStrategyFactory that is using the `targetResource` name for observability, contrary to the rest of the DefaultLoadBalancer which is using `lbDescription`. This happens because we accept a fully materialized ConnectionPoolStrategy in the DefaultLoadBalancer constructor instead of a factory like most everything else. Modifications: - Thread through the factory into the DefaultLoadBalancer constructor. - Fix the parameter names to reflect that it's now lbDescription being used.
bryce-anderson
deleted the
bl_anderson/threadThroughConnectionPoolStrategyFactory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have a type ConnectionPoolStrategyFactory that is using the
targetResourcename for observability, contrary to the rest of the DefaultLoadBalancer which is usinglbDescription. This happens because we accept a fully materialized ConnectionPoolStrategy in the DefaultLoadBalancer constructor instead of a factory like most everything else.Modifications: