h2: disable auto read for stream channels #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
commented
Jan 11, 2024
...y-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java
Outdated
Show resolved
Hide resolved
tkountis
reviewed
Jan 11, 2024
...y-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java
Outdated
Show resolved
Hide resolved
Scottmitch
commented
Jan 12, 2024
Scottmitch
force-pushed
the
h2_autoread
branch
3 times, most recently
from
d8db9cb to
42ce993
Compare
Motivation: HTTP/2 stream/child channel use cases don't disable autoRead explicitly. This means we may read and queue more data than desirable. Modifications: - Disable auto read for h2 stream/child channels.
Scottmitch
force-pushed
the
h2_autoread
branch
from
42ce993 to
e7e0068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HTTP/2 stream/child channel use cases don't disable autoRead explicitly. This means we may read and queue more data than desirable.
Modifications: