HTTP/2 requests can be sent with incorrect :scheme pseudo-header
#2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: apple#2672 changed the way we infer `waitForSslHandshake` flag. In case of ALPN, the handshake is already complete and the flag evaluated to `false`. However, `H2ToStH1ClientDuplexHandler` used the same flag for setting `:scheme` pseudo-header. As the result, client could send requests with `:scheme: http` instead of `https`. Modifications: - Use `parentContext.sslConfig()`/`connection.sslConfig()` to infer the correct scheme; - Promote `scheme` to `AbstractH2DuplexHandler` to use it on the server side for assertion (because `:scheme` is not propagated to users space, there is no otherwise an easy way to write an integration test that will evaluate received `:scheme`); Result: HTTP/2 client sends correct `:scheme`.
This reverts commit 1546062.
Scottmitch
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#2672 changed the way we infer
waitForSslHandshakeflag. In case of ALPN, the handshake is already complete and the flag is evaluated asfalse. However,H2ToStH1ClientDuplexHandlerused the same flag for setting:schemepseudo-header. As a result, client could send requests with:scheme: httpinstead ofhttps.Modifications:
parentContext.sslConfig()to infer the correct scheme forH2ToStH1ClientDuplexHandler;H2SchemeTestto validate the remote server received correct:schemein all cases;Result:
HTTP/2 client sends correct
:scheme.