Enhance NPE in operators that invoke functions #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some operators require a Functional interface that provide a non-null result (e.g. flatMap). When this scenario occurs as NPE is propagated however the control flow is async so it is challenging to determine where the code is that caused the NPE. Modifications: - Enhance the NPE to include a reference to the Functional interface which provides more context as to where the NPE originated from.
idelpivnitskiy
approved these changes
Jul 7, 2022
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutCompletable.java
Outdated
Show resolved
Hide resolved
bondolo
approved these changes
Jul 7, 2022
|
test failure due to #2265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some operators require a Functional interface that provide a
non-null result (e.g. flatMap). When this scenario occurs
as NPE is propagated however the control flow is async so
it is challenging to determine where the code is that caused
the NPE.
Modifications:
interface which provides more context as to where the NPE
originated from.