Completable/Single Processors more robust top of stack removal #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Completable/Single Processors make a best effort to remove nodes from the underlying data structure upon cancellation. However if the node is the last added and there is concurrent cancellation we may may fail to remove the node and give up leading to increased memory consumption. Modifications: - `ClosableConcurrentStack` should iterate the stack to remove the root node if the first removal attempt fails. Result: More robust cleanup of memory on removal.
Scottmitch
force-pushed
the
stack_top_remove
branch
from
3d0b2e5 to
e4e7c52
Compare
Scottmitch
added a commit
that referenced
this pull request
Mar 1, 2022
Motivation: Completable/Single Processors make a best effort to remove nodes from the underlying data structure upon cancellation. However if the node is the last added and there is concurrent cancellation we may may fail to remove the node and give up leading to increased memory consumption. Modifications: - `ClosableConcurrentStack` should iterate the stack to remove the root node if the first removal attempt fails. Result: More robust cleanup of memory on removal.
|
0.41 (805a73e) |
|
@idelpivnitskiy - +1 for cherry-pick. done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Completable/Single Processors make a best effort to remove
nodes from the underlying data structure upon cancellation.
However if the node is the last added and there is concurrent
cancellation we may may fail to remove the node and give up
leading to increased memory consumption.
Modifications:
ClosableConcurrentStackshould iterate the stack to removethe root node if the first removal attempt fails.
Result:
More robust cleanup of memory on removal.