Fix H2 Server with SNI bug #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: H2 server with SNI enabled current does not work. Netty's SniHandler does not queue writes in the same way that the SslHandler does. The h2 handler is added and writes a settings frame immediately on the server, which is written to the socket before the handshake is completed. This results in a handshake failure. Modifications: - Defer adding h2 protocol handlers to the pipeline until after the SNI selection is made. Result: H2 Server with SNI now works as expected.
chemicL
reviewed
Jul 13, 2021
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/SniCompleteChannelSingle.java
Outdated
Show resolved
Hide resolved
|
test failure attributed to #1663 |
idelpivnitskiy
approved these changes
Jul 14, 2021
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/SniTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/SniTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/SniTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/NettyHttpServer.java
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/SniCompleteChannelSingle.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/SniCompleteChannelSingle.java
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/SniTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/DeferredServerChannelBinder.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/DeferredServerChannelBinder.java
Outdated
Show resolved
Hide resolved
|
build failure attributed to #1507 |
Scottmitch
added a commit
that referenced
this pull request
Jul 15, 2021
Motivation: H2 server with SNI enabled current does not work. Netty's SniHandler does not queue writes in the same way that the SslHandler does. The h2 handler is added and writes a settings frame immediately on the server, which is written to the socket before the handshake is completed. This results in a handshake failure. Modifications: - Defer adding h2 protocol handlers to the pipeline until after the SNI selection is made. Result: H2 Server with SNI now works as expected.
|
0.41 (05a1cc5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
H2 server with SNI enabled current does not work. Netty's SniHandler
does not queue writes in the same way that the SslHandler does. The h2
handler is added and writes a settings frame immediately on the server,
which is written to the socket before the handshake is completed. This
results in a handshake failure.
Modifications:
selection is made.
Result:
H2 Server with SNI now works as expected.