Migrate servicetalk-data-jackson-jersey and servicetalk-http-router-jersey tests to junit5 #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade junit5 to version 5.8.0
danfaer
force-pushed
the
junit5-data-jackson-jersey
branch
from
9e1cc04 to
07393bc
Compare
44 tasks
idelpivnitskiy
approved these changes
Jul 6, 2021
| }) | ||
| public class JerseyDataJacksonTestSuite { | ||
| @SuiteDisplayName("Run JerseyRouterTestSuite with ServiceTalkJacksonSerializerAutoDiscoverable") | ||
| public class JerseyDataJacksonTestSuite extends BaseJerseyRouterTestSuite { |
This reverts commit 3234e71.
idelpivnitskiy
pushed a commit
that referenced
this pull request
Jul 15, 2021
…ersey tests to junit5 (#1645) Motivation: JUnit 5 leverages features from Java 8 or later, such as lambda functions, making tests more powerful and easier to maintain. JUnit 5 has added some very useful new features for describing, organizing, and executing tests. For instance, tests get better display names and can be organized hierarchically. JUnit 5 is organized into multiple libraries, so only the features you need are imported into your project. With build systems such as Maven and Gradle, including the right libraries is easy. JUnit 5 can use more than one extension at a time, which JUnit 4 could not (only one runner could be used at a time). This means you can easily combine the Spring extension with other extensions (such as your own custom extension). Modifications: Unit tests have been migrated from JUnit 4 to JUnit 5 Upgraded junit5 to version 5.0.8 as it supports declarative test suits Result: Modules servicetalk-data-jackson-jersey and servicetalk-http-router-jersey now run tests and test suits using JUnit 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
JUnit 5 leverages features from Java 8 or later, such as lambda functions, making tests more powerful and easier to maintain.
JUnit 5 has added some very useful new features for describing, organizing, and executing tests. For instance, tests get better display names and can be organized hierarchically.
JUnit 5 is organized into multiple libraries, so only the features you need are imported into your project. With build systems such as Maven and Gradle, including the right libraries is easy.
JUnit 5 can use more than one extension at a time, which JUnit 4 could not (only one runner could be used at a time). This means you can easily combine the Spring extension with other extensions (such as your own custom extension).
Modifications:
Unit tests have been migrated from JUnit 4 to JUnit 5
Upgraded junit5 to version 5.0.8 as it supports declarative test suits
Result:
Modules servicetalk-data-jackson-jersey and servicetalk-http-router-jersey now run tests and test suits using JUnit 5
#1568