TestSubscription#requestedEquals(0) incorrectly validates the value
#1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `TestSubscription#requestedEquals` depends on the passed `value` and if `value == 0` it does not check the current cumulative value of requested elements, it only checks if `request(long)` was ever invoked or not. Modifications: - Fix validation in `TestSubscription#requestedEquals`; - Adjust existing tests to account for new behavior; Result: `TestSubscription#requestedEquals(0)` validates that `request(long)` was invoked and the current cumulative value if equal to `0`.
1 task
Scottmitch
approved these changes
Jun 28, 2021
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Jul 2, 2021
…apple#1642) Motivation: `TestSubscription#requestedEquals` depends on the passed `value` and if `value == 0` it does not check the current cumulative value of requested elements, it only checks if `request(long)` was ever invoked or not. Modifications: - Fix validation in `TestSubscription#requestedEquals`; - Adjust existing tests to account for new behavior; Result: `TestSubscription#requestedEquals(0)` validates that `request(long)` was invoked and the current cumulative value if equal to `0`.
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Jul 2, 2021
…apple#1642) Motivation: `TestSubscription#requestedEquals` depends on the passed `value` and if `value == 0` it does not check the current cumulative value of requested elements, it only checks if `request(long)` was ever invoked or not. Modifications: - Fix validation in `TestSubscription#requestedEquals`; - Adjust existing tests to account for new behavior; Result: `TestSubscription#requestedEquals(0)` validates that `request(long)` was invoked and the current cumulative value if equal to `0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TestSubscription#requestedEqualsdepends on the passedvalueand ifvalue == 0it does not check the current cumulative value of requestedelements, it only checks if
request(long)was ever invoked or not.Modifications:
TestSubscription#requestedEquals;Result:
TestSubscription#requestedEquals(0)validates thatrequest(long)wasinvoked and the current cumulative value if equal to
0.