Fix PublisherFlatMapSingle's demand handling #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
force-pushed
the
fix/flatMapSingle_drain_count
branch
from
a61e2a2 to
ecc69e2
Compare
bondolo
approved these changes
Jun 21, 2021
|
Build failure #1579 |
idelpivnitskiy
approved these changes
Jun 21, 2021
...k-concurrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapSingleTest.java
Outdated
Show resolved
Hide resolved
...k-concurrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapSingleTest.java
Show resolved
Hide resolved
...k-concurrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapSingleTest.java
Outdated
Show resolved
Hide resolved
tkountis
force-pushed
the
fix/flatMapSingle_drain_count
branch
2 times, most recently
from
3c685aa to
fb6bc84
Compare
Motivation: PublisherFlatMapSingle was recently changed to better handle excpetions, but the changes affected the way the drain counter was updating, which as a result created wrong demand upstream. Modifications: Init the counter inside the loop to reset it everytime there is contention and the lock is re-acquired. Result: Proper counting of delivered items and thus proper demand requests.
tkountis
force-pushed
the
fix/flatMapSingle_drain_count
branch
from
fb6bc84 to
c354772
Compare
bondolo
pushed a commit
that referenced
this pull request
Jun 28, 2021
Motivation: PublisherFlatMapSingle was recently changed to better handle excpetions, but the changes affected the way the drain counter was updating, which as a result created wrong demand upstream. Modifications: Init the counter inside the loop to reset it everytime there is contention and the lock is re-acquired. Result: Proper counting of delivered items and thus proper demand requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
PublisherFlatMapSingle was recently changed to better handle excpetions, but the changes
affected the way the drain counter was updating, which as a result created wrong demand upstream.
Modifications:
Init the counter inside the loop to reset it everytime there is contention and the lock is re-acquired.
Result:
Proper counting of delivered items and thus proper demand requests.