Prevent memory leak if HTTP/1.1 encoding fails #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When `HttpObjectEncoder` encodes meta-data or trailers an error may happen, which will cause a leak of internal `ByteBuf`. It may happen if any of the encoding object throw or if it tries to expand the size of that internal `ByteBuf` without success. Modifications: - try-catch meta-data and trailers encoding and release the tmp `ByteBuf` in case of any failures; Result: Internal `ByteBuf` does not leak in case of an error in `HttpObjectEncoder`.
idelpivnitskiy
commented
Jun 4, 2021
| try { | ||
| buf.writeCharSequence(lengthHex, US_ASCII); | ||
| writeShortBE(buf, CRLF_SHORT); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
This code is unlikely to fail. Added try-catch here for consistency, more safety, and better sleep :)
NiteshKant
approved these changes
Jun 7, 2021
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/HttpObjectEncoder.java
Outdated
Show resolved
Hide resolved
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Jun 8, 2021
Motivation: When `HttpObjectEncoder` encodes meta-data or trailers an error may happen, which will cause a leak of internal `ByteBuf`. It may happen if any of the encoding object throw or if it tries to expand the size of that internal `ByteBuf` without success. Modifications: - try-catch meta-data and trailers encoding and release the tmp `ByteBuf` in case of any failures; Result: Internal `ByteBuf` does not leak in case of an error in `HttpObjectEncoder`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When
HttpObjectEncoderencodes meta-data or trailers an error mayhappen, which will cause a leak of internal
ByteBuf. It may happen ifany of the encoding object throw or if it tries to expand the size of
that internal
ByteBufwithout success.Modifications:
ByteBufin case of any failures;Result:
Internal
ByteBufdoes not leak in case of an error inHttpObjectEncoder.